Conversation
…s for pointer init Two fixes for combined pointer declaration+initialization from struct fields (e.g. `int16_t *r = p->coeffs;`) generating unnecessary c_cast_to_void/c_cast_from_void roundtrips that the separate declaration+assignment path avoids: 1. mk_implicit_cast: in the T*->U* reinterpret case, skip the void roundtrip when both inner types have the same HOL representation (catches CLong/CLongLong on LP64, typedef-resolved variants, etc.) 2. process_one (CInitExpr0): for pointer init from array-backed struct fields, skip mk_implicit_cast entirely — matching the separate assignment path which binds the RHS directly without any cast. Guarded by alias_list_backed to ensure alias storage is used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes for combined pointer declaration+initialization from struct fields (e.g.
int16_t *r = p->coeffs;) generating unnecessary c_cast_to_void/c_cast_from_void roundtrips that the separate declaration+assignment path avoids:mk_implicit_cast: in the T*->U* reinterpret case, skip the void roundtrip when both inner types have the same HOL representation (catches CLong/CLongLong on LP64, typedef-resolved variants, etc.)
process_one (CInitExpr0): for pointer init from array-backed struct fields, skip mk_implicit_cast entirely — matching the separate assignment path which binds the RHS directly without any cast. Guarded by alias_list_backed to ensure alias storage is used.