Apply consistent code style and common code fixes.#7
Open
tg73 wants to merge 8 commits intoDominicBeer:masterfrom
Open
Apply consistent code style and common code fixes.#7tg73 wants to merge 8 commits intoDominicBeer:masterfrom
tg73 wants to merge 8 commits intoDominicBeer:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @DominicBeer - apologies for not discussing with you first. I just needed to get on with some enhancements for my own use case, and needed a consistent starting point. I totally understand if you don't want to merge this. The existing codebase was a bit inconsistent, for example sometimes using
this.and sometimes not. I've added.editorconfigand JetBrains style settings for the coding style I'm used to using in a professional setting. I think it's quite close to the existing style.All tests in
gh-testingpass, including the manual ones.