extend header encoding to cover control characters#224
Merged
andrewtimberlake merged 1 commit intoDockYard:masterfrom Mar 5, 2026
Merged
extend header encoding to cover control characters#224andrewtimberlake merged 1 commit intoDockYard:masterfrom
andrewtimberlake merged 1 commit intoDockYard:masterfrom
Conversation
Member
|
@andrewtimberlake this is 👍 from me. |
Collaborator
|
Looks good. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
outputs the following:
With this PR applied:
Changes proposed in this pull request
Need to encode more than just non-ASCII as control characters can change how a header is read. People shouldn't be putting in control characters, but it's safer to just encode any that may occur.
This only recently became a problem due to #214 . Before that, the comparison between encoded and non-encoded would have been false and it would have used the encoded version.