fix: store.update 실패 시 오버레이 리사이즈가 중단되는 문제 수정#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
개요
resize_overlay에서store.update(...)?로 디스크 저장이 실패하면 함수가 조기 종료되어 UI 반영이 중단되는 문제 수정변경 내용
overlay_last_content_top_offset저장 실패 시window.set_size/set_position이 스킵되어 창 크기와 내부 콘텐츠가 어긋나는 문제 수정overlay_bounds저장 실패 시overlay:resized이벤트가 발송되지 않아 프론트엔드 상태 불일치가 발생하는 문제 수정store.update는 실패해도 메모리 롤백이 없으므로,?대신if let Err+log::warn으로 변경하여 UI 로직은 끝까지 실행되도록 처리