fix: GCC 13+ build and RPC passwords with special characters#23
Open
JohnnyLawDGB wants to merge 1 commit intoDigiAsset-Core:developmentfrom
Open
fix: GCC 13+ build and RPC passwords with special characters#23JohnnyLawDGB wants to merge 1 commit intoDigiAsset-Core:developmentfrom
JohnnyLawDGB wants to merge 1 commit intoDigiAsset-Core:developmentfrom
Conversation
- Add missing #include <cstdint> to Blob.h — GCC 13 (Ubuntu 24.04) no longer implicitly includes it via other headers, causing build failure. - URL-encode rpcuser and rpcpassword when constructing the HTTP basic auth URL for jsonrpc::HttpClient. Passwords containing /, +, =, or @ broke the URL parsing and caused "DigiByte Core Offline" errors even when the node was running and the credentials were correct. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <cstdint>toBlob.h— GCC 13 (Ubuntu 24.04) no longer implicitly includes it, causing build failure onuint8_treferencesrpcuserandrpcpasswordwhen constructing the HTTP basic auth URL — passwords containing/,+,=, or@broke URL parsing and caused false "DigiByte Core Offline" errorsContext
Discovered while building on Ubuntu 24.04 LTS with GCC 13.3.0. The
cstdintissue is a known GCC 13 change affecting many C++ projects. The URL encoding issue affects anyone whosedigibyte.confhas an auto-generatedrpcpasswordcontaining base64 characters.Test plan
/,+,=🤖 Generated with Claude Code