Change from stateful set to deployment#257
Change from stateful set to deployment#257ZohebShaikh wants to merge 1 commit intoDiamondLightSource:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=======================================
Coverage 76.35% 76.35%
=======================================
Files 13 13
Lines 1937 1937
=======================================
Hits 1479 1479
Misses 458 458 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The container build image Is failing because I have given a PR from a fork I have tested this on p46 And I could not find any significant difference between using Deployment and statefulset The deployment pod was back in 4 seconds and the stateful set was back in about 10 seconds |
tpoliaw
left a comment
There was a problem hiding this comment.
I'm still unsure if this is required/the best way of doing it but we can try it in staging and see how it gets on
Presumably the previous pod was still functional until the new one was up? If it wasn't, there isn't much benefit to this change. |
closes #200