Skip to content

Change from stateful set to deployment#257

Open
ZohebShaikh wants to merge 1 commit intoDiamondLightSource:mainfrom
ZohebShaikh:add-deployment
Open

Change from stateful set to deployment#257
ZohebShaikh wants to merge 1 commit intoDiamondLightSource:mainfrom
ZohebShaikh:add-deployment

Conversation

@ZohebShaikh
Copy link
Contributor

@ZohebShaikh ZohebShaikh commented Mar 4, 2026

closes #200

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.35%. Comparing base (8575746) to head (0a4b2ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   76.35%   76.35%           
=======================================
  Files          13       13           
  Lines        1937     1937           
=======================================
  Hits         1479     1479           
  Misses        458      458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZohebShaikh ZohebShaikh requested a review from tpoliaw March 4, 2026 15:05
@ZohebShaikh
Copy link
Contributor Author

ZohebShaikh commented Mar 4, 2026

The container build image Is failing because I have given a PR from a fork

I have tested this on p46 And I could not find any significant difference between using Deployment and statefulset

The deployment pod was back in 4 seconds and the stateful set was back in about 10 seconds

Copy link
Collaborator

@tpoliaw tpoliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still unsure if this is required/the best way of doing it but we can try it in staging and see how it gets on

@tpoliaw
Copy link
Collaborator

tpoliaw commented Mar 11, 2026

The deployment pod was back in 4 seconds

Presumably the previous pod was still functional until the new one was up? If it wasn't, there isn't much benefit to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate using deployment instead of stateful set in helm chart

2 participants