Draft
Conversation
1. replace .so with .dylib 2. recognise non-x64 processors Towards DiamondLightSource#33
Contributor
|
The CI failures are due to the CI not being run for years, and a lot of stuff is now deprecated or straight up removed. I plan to adopt the Diamond python copier template to this repo, hopefully in the immediate future. This will mean the project will no longer support Python2.7, nor various Python3 versions. I hope this won't be a problem for you. |
Contributor
|
I've merged in PR #36, which rewrites the CI (and many other things). Please rebase this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #33
This is in the "ugly but works" category, suspect more elegant solution possible
As mentioned in #33 overriding with environment variable can address point 2, but point 1 needs
at the least