Allow inserting feature flag macros on info fields#27
Allow inserting feature flag macros on info fields#27
Conversation
coretl
left a comment
coretl
left a comment
There was a problem hiding this comment.
Please could we have some docs too, and could you regenerate the Pipfile.lock internally to see if it fixes things?
GDYendell
force-pushed
the
info-feature-flags
branch
2 times, most recently
from
73c599d to
8188389
Compare
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 82.87% 81.88% -1.00%
==========================================
Files 10 10
Lines 584 585 +1
==========================================
- Hits 484 479 -5
- Misses 100 106 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
GDYendell
force-pushed
the
info-feature-flags
branch
2 times, most recently
from
84da8be to
710655c
Compare
|
The builds that need to install EPICS base are failing for some reason. I think that is also causing the coverage decrease. |
|
Well at least epics-modules/pcas@56403e8 looks like an easy enough patch to apply. |
GDYendell
force-pushed
the
info-feature-flags
branch
14 times, most recently
from
20586c3 to
b233580
Compare
|
14th time lucky. Now codecov is failing because the windows build failed to upload its report... |
GDYendell
force-pushed
the
info-feature-flags
branch
from
8d02106 to
25dedf4
Compare
GDYendell
force-pushed
the
info-feature-flags
branch
from
25dedf4 to
554afa5
Compare
|
Apologies for the many builds. I think this is ready for review now. |
|
I'm happy with this. @Araneidae are we ok to merge and release? |
Araneidae
left a comment
Araneidae
left a comment
There was a problem hiding this comment.
Looks good, except I'd like to see the dropping of legacy support done more explicitly.
Add 3.9 to supported list, as it is tested in CI
GDYendell
force-pushed
the
info-feature-flags
branch
from
554afa5 to
50cf4cf
Compare
| Programming Language :: Python :: 3.6 | ||
| Programming Language :: Python :: 3.7 | ||
| Programming Language :: Python :: 3.8 | ||
| Programming Language :: Python :: 3.9 |
There was a problem hiding this comment.
Can we add 3.10, 3.11, 3.12, or do we depend on epicscorelibs? Probably not a question for this PR.
|
I think this must be good to merge, not sure why it's still hanging fire! Is this feature still wanted? |
|
The immediate use case for this has been deferred, but I think it would be good to merge anyway. |
3 participants
No description provided.