Skip to content

Fix currency duplication exploit #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxijonson wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

Fix currency duplication exploit #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Quests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -961,6 +961,10 @@ private string GetRewardString(List<RewardItem> entry)

private bool GiveReward(BasePlayer player, List<RewardItem> rewards)
{
var countItemRewards = rewards.Count(r => !string.IsNullOrEmpty(r.ShortName));
var usedItemSlots = player.inventory.containerMain.itemList.Count + player.inventory.containerBelt.itemList.Count;
if (usedItemSlots + countItemRewards > 30) return false;

foreach (var reward in rewards)
{
if (reward.isCoins && Economics)
Expand All @@ -981,7 +985,6 @@ private bool GiveReward(BasePlayer player, List<RewardItem> rewards)
var definition = FindItemDefinition(reward.ShortName);
if (definition != null)
{
if (player.inventory.AllItems().Count() >= 30) return false;
var item = ItemManager.Create(definition, (int)reward.Amount, reward.Skin);
if (item != null)
{
Expand Down