fix: keep dependabot remediation compatible with minSdk 23#286
Merged
jonathannorris merged 1 commit intomainfrom Mar 19, 2026
Merged
fix: keep dependabot remediation compatible with minSdk 23#286jonathannorris merged 1 commit intomainfrom
jonathannorris merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR keeps the Android Client SDK compatible with minSdk 23 while retaining prior security/dependency remediation work by selectively pinning jackson-module-kotlin to an API-23-compatible version and updating build tooling.
Changes:
- Upgrade build tooling: Gradle wrapper to 8.13 and Android Gradle Plugin to 8.13.2, plus add repository-wide forced patches for vulnerable transitive deps.
- Keep Jackson remediation without raising
minSdkby holdingjackson-module-kotlinto 2.19.1 (strict), while moving other Jackson modules to 2.21.1. - Update README requirements line to clarify min supported Android release.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
build.gradle |
Bumps AGP and introduces global resolutionStrategy.force rules for patched transitive dependencies. |
gradle/wrapper/gradle-wrapper.properties |
Updates the root Gradle wrapper distribution to 8.13. |
android-client-sdk/build.gradle |
Updates Jackson versions and strictly pins jackson-module-kotlin to avoid raising minSdk. |
README.md |
Clarifies the min API requirement with Android version/date context. |
openfeature-example/build.gradle |
Minor wrapper task hunk touched (closing brace), but still defines a per-module wrapper version. |
kotlin-example/build.gradle |
Minor wrapper task hunk touched (closing brace), but still defines a per-module wrapper version. |
java-example/build.gradle |
Minor wrapper task hunk touched (closing brace), but still defines a per-module wrapper version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
822d089 to
46891d7
Compare
jsalaber
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minSdkjackson-module-kotlinto2.19.1using a strict version sojackson-bomdoesn't upgrade it to a build that requires API 262.21.1and retain the forced patched build-time transitive dependencies from the AGP upgradeThis PR
The main blocker for staying on API 23 is
jackson-module-kotlin2.21+, which usesMethodHandle.invokeExactand effectively requiresminSdk 26.I think it probably makes sense to keep
jackson-core/jackson-databind/jackson-datatype-json-orgon the patched versions, while holding onlyjackson-module-kotlinback to2.19.1until we intentionally raise the Android floor.Verification
./gradlew :android-client-sdk:dependencies --configuration releaseRuntimeClasspath./gradlew buildEnvironment./gradlew testrequires a local Android SDK and couldn't run in this environment.Related Issues