Issue #1797 fix api generate index array#1798
Merged
JoerivanEngelen merged 6 commits intomasterfrom Mar 31, 2026
Merged
Conversation
Manangka
approved these changes
Mar 30, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #1797
Description
This PR changes the following:
GridData.generate_index_arrayreturns the same as it did in iMOD Python 1.0, throw DeprecationWarning urging users to update toGridData.generate_isactive_svat_array.GridData.generate_isactive_svat_arrayand add it to public API docsindexto the more descriptiveisactive, as the variable is in fact NOT an index. In a further PR we can rename this variable throughout the complete MetaSWAP module, which will affect a lot of files. I think that is worthy a separate PR.Checklist
Issue #nr, e.g.Issue #737pixi run generate-sbomand committed changes