Skip to content

Fix installer fallback and version bump workflow#182

Merged
DeanoC merged 3 commits intomainfrom
codex/spiderweb-review-fixes
Mar 26, 2026
Merged

Fix installer fallback and version bump workflow#182
DeanoC merged 3 commits intomainfrom
codex/spiderweb-review-fixes

Conversation

@DeanoC
Copy link
Owner

@DeanoC DeanoC commented Mar 26, 2026

Summary

  • avoid exiting early when share-tree deletion needs sudo during install upgrades
  • let bump-version.sh succeed before CHANGELOG.md is updated
  • address the two Codex review findings left on PR Release Spiderweb 0.5.1 #179

Testing

  • bash -n install.sh scripts/bump-version.sh
  • tmpdir=$(mktemp -d) && rsync -a --exclude .git ./ "$tmpdir/" >/dev/null && cd "$tmpdir" && ./scripts/bump-version.sh --patch
  • mocked shell test covering copy_spidervenoms_share_tree and copy_spiderweb_share_tree sudo fallback path

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a57337b9f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@DeanoC DeanoC merged commit d4df74a into main Mar 26, 2026
13 checks passed
@DeanoC DeanoC deleted the codex/spiderweb-review-fixes branch March 26, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant