-
Notifications
You must be signed in to change notification settings - Fork 0
Increase rate limit #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -34,13 +34,13 @@ export const POST: RequestHandler<NextRouteContext> = withApiKey( | |||||
| withEventRateLimit( | ||||||
| { | ||||||
| eventType: "fetch_updated_data_1d", | ||||||
| maxRequests: 100, | ||||||
| maxRequests: 500, | ||||||
| windowMs: 24 * 60 * 60 * 1000, | ||||||
| }, // 24 hours | ||||||
| withEventRateLimit( | ||||||
| { | ||||||
| eventType: "fetch_updated_data_5m", | ||||||
| maxRequests: 10, | ||||||
| maxRequests: 25, | ||||||
|
||||||
| maxRequests: 25, | |
| maxRequests: 50, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This endpoint makes external Google API calls (via updateBusinessReviews and updateBusinessStats) which may have associated costs or quotas. A 5x increase in the daily rate limit could significantly increase API usage and costs. Consider whether this increase aligns with Google API quotas and budget constraints, especially since this endpoint is called by 11ty during client website rebuilds.