Skip to content

dm-pcache: remove unused segment position struct and helper function #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zenglg wants to merge 1 commit into
base: dm-pcache
Choose a base branch
from
Open

dm-pcache: remove unused segment position struct and helper function #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions drivers/md/dm-pcache/segment.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ static inline u8 segment_info_get_type(struct pcache_segment_info *seg_info)
return FIELD_GET(PCACHE_SEG_INFO_FLAGS_TYPE_MASK, seg_info->flags);
}

struct pcache_segment_pos {
struct pcache_segment *segment; /* Segment associated with the position */
u32 off; /* Offset within the segment */
};

struct pcache_segment_init_options {
u8 type;
u32 seg_id;
Expand All @@ -62,13 +57,6 @@ int segment_copy_to_bio(struct pcache_segment *segment,
int segment_copy_from_bio(struct pcache_segment *segment,
u32 data_off, u32 data_len, struct bio *bio, u32 bio_off);

static inline void segment_pos_advance(struct pcache_segment_pos *seg_pos, u32 len)
{
BUG_ON(seg_pos->off + len > seg_pos->segment->data_size);

seg_pos->off += len;
}

void pcache_segment_init(struct pcache_cache_dev *cache_dev, struct pcache_segment *segment,
struct pcache_segment_init_options *options);
#endif /* _PCACHE_SEGMENT_H */