Skip to content

[BDMS-633]: "Site Name" not showing actual site name on well details page and field compilation sheet#210

Merged
TylerAdamMartinez merged 6 commits intostagingfrom
FIX_TAM_BDMS_-633
Mar 13, 2026
Merged

[BDMS-633]: "Site Name" not showing actual site name on well details page and field compilation sheet#210
TylerAdamMartinez merged 6 commits intostagingfrom
FIX_TAM_BDMS_-633

Conversation

@TylerAdamMartinez
Copy link
Contributor

@TylerAdamMartinez TylerAdamMartinez commented Mar 11, 2026

Why

This PR addresses the following problem/context:

  • Ensure the UI displays the Bureau-assigned site name for wells.
    • Correctly filter alternate IDs to match the database rules (relation = same_as, alternate_organization = NMBGMR).

How

Implementation summary - the following was changed/added/removed:

  • Updated the site name lookup to filter alternate_ids using relation === "same_as" and alternate_organization === "NMBGMR".

Notes

Any special considerations, workarounds, or follow-up work to note?

  • If multiple matches exist, the first matching value is used.

@TylerAdamMartinez TylerAdamMartinez added the bug Something isn't working label Mar 11, 2026
@TylerAdamMartinez
Copy link
Contributor Author

Before:

light mode

Captura de pantalla 2026-03-11 a la(s) 16 23 01

dark mode

Captura de pantalla 2026-03-11 a la(s) 16 23 17

After:

light mode

Captura de pantalla 2026-03-11 a la(s) 16 28 19

dark mode

Captura de pantalla 2026-03-11 a la(s) 16 29 01

@jeremyzilar
Copy link
Contributor

Looking good sir!
You might mirror the same language and order being used on the DataGrid component:
image

@TylerAdamMartinez TylerAdamMartinez changed the title [BDMS-123]: [BDMS-633]: Fix site_name bug Mar 12, 2026
@TylerAdamMartinez
Copy link
Contributor Author

TylerAdamMartinez commented Mar 12, 2026

Looking good sir! You might mirror the same language and order being used on the DataGrid component: image

@jeremyzilar, the radio group has been updated to use consistent language and iconography

light mode

Captura de pantalla 2026-03-12 a la(s) 14 50 09

dark mode

Captura de pantalla 2026-03-12 a la(s) 14 50 25

@TylerAdamMartinez TylerAdamMartinez changed the title [BDMS-633]: Fix site_name bug [BDMS-633]: "Site Name" not showing actual site name on well details page and field compilation sheet Mar 12, 2026
@TylerAdamMartinez TylerAdamMartinez self-assigned this Mar 12, 2026
@TylerAdamMartinez TylerAdamMartinez marked this pull request as ready for review March 12, 2026 19:32
Copy link

@ksmuczynski ksmuczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic to find site name looks good. Approved on my end.

@TylerAdamMartinez TylerAdamMartinez merged commit 7583dc3 into staging Mar 13, 2026
2 of 3 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the FIX_TAM_BDMS_-633 branch March 13, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Site Name" not showing actual site name on well details page and field compilation sheet

4 participants