[CONTINT-5127] Update cluster naming rules#35000
Open
Conversation
Contributor
Preview links (active after the
|
buraizu
reviewed
Mar 4, 2026
Contributor
buraizu
left a comment
buraizu
left a comment
There was a problem hiding this comment.
Requesting one minor style edit, and posted a question
content/en/containers/guide/kubernetes-cluster-name-detection.md
Outdated
Show resolved
Hide resolved
| <li/>Must contain only lowercase letters, numbers, dots, hyphens and underscores | ||
| <li/>Must start with an alphanumeric character | ||
| <li/>Must end with an alphanumeric character | ||
| <li/>Must be FQDN-like, without a trailing period |
Contributor
There was a problem hiding this comment.
FQDN-like is somewhat vague, and may be confusing for some users, such as those who do not speak English natively. A couple of update options come to mind:
- Remove
FQDN-likeand be more specific about the criterion (for example, "must not have a trailing period") - Spell out the acronym (for example, "Similar to a Fully Qualified Domain Name (FQDN), without a trailing period")
The first option seems the least ambiguous to me. What do you think?
Contributor
Author
There was a problem hiding this comment.
I think we need to mention that we support FQDN "like" cluster names since its otherwise not obvious that we support cluster names like "my.example-cluster.com". I would prefer the 2nd option.
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
This PR updates the Kubernetes cluster naming rules to align with the updates coming to the agent and the helm chart.
DataDog/helm-charts#2428
DataDog/datadog-agent#47189
Merge instructions
Should wait until the next major agent release to be merged (v7.78.0).
Merge readiness:
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
Additional notes