chore(ci): add final_status property on junit XML [APMSP-2610]#3693
Draft
cbeauchesne wants to merge 3 commits intomasterfrom
Draft
chore(ci): add final_status property on junit XML [APMSP-2610]#3693cbeauchesne wants to merge 3 commits intomasterfrom
cbeauchesne wants to merge 3 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3693 +/- ##
==========================================
- Coverage 62.44% 62.40% -0.04%
==========================================
Files 142 142
Lines 13586 13586
Branches 1775 1775
==========================================
- Hits 8484 8479 -5
- Misses 4296 4301 +5
Partials 806 806 see 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
✨ Fix all issues with BitsAI or with Cursor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a
<property name="dd_tags[test.final_status]" value="pass" />on every test case reported through junitMotivation
Some repositories intentionally use mechanisms that ignore test failures (there are valid reasons to still execute those tests behind the scenes).
In these cases, the reported test status cannot be relied upon by Test Optimization to monitor repository health or trigger team notifications.
To ensure a consistent and unified approach, we will instead use final_status — the property specifically designed and used by the Test Optimization integration for this purpose.
Important note
I'm using the not-that-ideal XSLT here as this change, because it must be done over 17+ repos, and it's a workaround until this gets integrated into a better place, such as datadog-ci or the backend.
We're trying to work with the team on this, please have a look on this RFC for more context.
Reviewer checklist