Skip to content

chore(ci): add final_status property on junit XML [APMSP-2610]#3693

Draft
cbeauchesne wants to merge 3 commits intomasterfrom
cbeauchesne/final_status
Draft

chore(ci): add final_status property on junit XML [APMSP-2610]#3693
cbeauchesne wants to merge 3 commits intomasterfrom
cbeauchesne/final_status

Conversation

@cbeauchesne
Copy link
Collaborator

@cbeauchesne cbeauchesne commented Mar 6, 2026

What does this PR do?

Add a <property name="dd_tags[test.final_status]" value="pass" /> on every test case reported through junit

Motivation

Some repositories intentionally use mechanisms that ignore test failures (there are valid reasons to still execute those tests behind the scenes).

In these cases, the reported test status cannot be relied upon by Test Optimization to monitor repository health or trigger team notifications.

To ensure a consistent and unified approach, we will instead use final_status — the property specifically designed and used by the Test Optimization integration for this purpose.

Important note

I'm using the not-that-ideal XSLT here as this change, because it must be done over 17+ repos, and it's a workaround until this gets integrated into a better place, such as datadog-ci or the backend.

We're trying to work with the team on this, please have a look on this RFC for more context.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.40%. Comparing base (b33ea57) to head (0b39b96).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3693      +/-   ##
==========================================
- Coverage   62.44%   62.40%   -0.04%     
==========================================
  Files         142      142              
  Lines       13586    13586              
  Branches     1775     1775              
==========================================
- Hits         8484     8479       -5     
- Misses       4296     4301       +5     
  Partials      806      806              

see 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33ea57...0b39b96. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1-2
Copy link

datadog-datadog-prod-us1-2 bot commented Mar 9, 2026

⚠️ Tests

Fix all issues with BitsAI or with Cursor

⚠️ Warnings

🧪 1028 Tests failed

testSearchPhpBinaries from integration.DDTrace\Tests\Integration\PHPInstallerTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integration\PHPInstallerTest::testSearchPhpBinaries
Test code or tested code printed unexpected output: Searching for available php binaries, this operation might take a while.
testSimplePushAndProcess from laravel-58-test.DDTrace\Tests\Integrations\Laravel\V5_8\QueueTest (Datadog) (Fix with Cursor)
Risky Test
phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:97
testSimplePushAndProcess from laravel-8x-test.DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest (Datadog) (Fix with Cursor)
DDTrace\Tests\Integrations\Laravel\V8_x\QueueTest::testSimplePushAndProcess
Test code or tested code printed unexpected output: spanLinksTraceId: 69aee8760000000086c99313ea021315
tid: 69aee87600000000
hexProcessTraceId: 86c99313ea021315
hexProcessSpanId: 055dbb470ea85e0e
processTraceId: 9712455785140851477
processSpanId: 386671056886717966

phpvfscomposer://tests/vendor/phpunit/phpunit/phpunit:106
View all

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0b39b96 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants