chore(ci): use 15 percent impact threshold for SLOs#7930
Conversation
Overall package sizeSelf size: 5.47 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7930 +/- ##
=======================================
Coverage 74.26% 74.26%
=======================================
Files 769 769
Lines 36063 36063
=======================================
Hits 26782 26782
Misses 9281 9281 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: 1edf3b7 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback! |
BenchmarksBenchmark execution time: 2026-04-07 19:11:21 Comparing candidate commit 1edf3b7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 229 metrics, 31 unstable metrics. |
faydef
changed the title
2 participants
What does this PR do?
Loosens auto-generated SLO thresholds by increasing the significant impact threshold (T) from 5% to 15%.
Motivation
Benchmarks were producing false positive SLO breaches due to cross-run variability. The 5% margin above the CI bound was too tight, causing noise between runs to trigger failures. A 15% margin provides enough headroom to absorb this variability while still catching meaningful regressions.
Additional Notes
Only thresholds that were brought up in the OE report were changed.