Skip to content

docs(skill): add code review skill#7888

Open
ida613 wants to merge 3 commits intomasterfrom
ida613/code-review-skill-new
Open

docs(skill): add code review skill#7888
ida613 wants to merge 3 commits intomasterfrom
ida613/code-review-skill-new

Conversation

@ida613
Copy link
Copy Markdown
Collaborator

@ida613 ida613 commented Mar 30, 2026

What does this PR do?

in an attempt to speed up code review (maybe)

Motivation

Additional Notes

ida613 and others added 2 commits March 30, 2026 13:41
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.27%. Comparing base (edb4236) to head (7458570).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7888      +/-   ##
==========================================
- Coverage   74.39%   74.27%   -0.12%     
==========================================
  Files         768      765       -3     
  Lines       35800    35793       -7     
==========================================
- Hits        26633    26586      -47     
- Misses       9167     9207      +40     
Flag Coverage Δ
aiguard-macos 39.41% <ø> (+0.08%) ⬆️
aiguard-ubuntu 39.53% <ø> (+0.08%) ⬆️
aiguard-windows 39.20% <ø> (+0.07%) ⬆️
apm-capabilities-tracing-macos 49.18% <ø> (+0.14%) ⬆️
apm-capabilities-tracing-ubuntu 49.10% <ø> (+0.14%) ⬆️
apm-capabilities-tracing-windows 48.96% <ø> (+0.14%) ⬆️
apm-integrations-child-process 38.74% <ø> (+0.07%) ⬆️
apm-integrations-couchbase-18 37.52% <ø> (+0.20%) ⬆️
apm-integrations-couchbase-eol 38.01% <ø> (+0.06%) ⬆️
apm-integrations-oracledb 37.87% <ø> (+0.09%) ⬆️
appsec-express 55.39% <ø> (+0.15%) ⬆️
appsec-fastify 51.72% <ø> (+0.12%) ⬆️
appsec-graphql 51.87% <ø> (+0.11%) ⬆️
appsec-kafka 44.49% <ø> (+0.09%) ⬆️
appsec-ldapjs 44.11% <ø> (+0.09%) ⬆️
appsec-lodash 43.71% <ø> (+0.09%) ⬆️
appsec-macos 58.15% <ø> (-0.03%) ⬇️
appsec-mongodb-core 48.89% <ø> (+0.11%) ⬆️
appsec-mongoose 49.55% <ø> (+0.12%) ⬆️
appsec-mysql 51.07% <ø> (+0.21%) ⬆️
appsec-node-serialize 43.29% <ø> (+0.09%) ⬆️
appsec-passport 47.76% <ø> (+0.12%) ⬆️
appsec-postgres 50.70% <ø> (+0.12%) ⬆️
appsec-sourcing 42.54% <ø> (+0.08%) ⬆️
appsec-stripe 44.73% <ø> (+0.10%) ⬆️
appsec-template 43.46% <ø> (+0.09%) ⬆️
appsec-ubuntu 58.23% <ø> (-0.01%) ⬇️
appsec-windows 57.97% <ø> (-0.03%) ⬇️
instrumentations-instrumentation-bluebird 32.32% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-body-parser 40.63% <ø> (+0.08%) ⬆️
instrumentations-instrumentation-child_process 38.07% <ø> (+0.06%) ⬆️
instrumentations-instrumentation-cookie-parser 34.35% <ø> (+0.03%) ⬆️
instrumentations-instrumentation-express 34.67% <ø> (+0.03%) ⬆️
instrumentations-instrumentation-express-mongo-sanitize 34.48% <ø> (+0.03%) ⬆️
instrumentations-instrumentation-express-session 40.27% <ø> (+0.08%) ⬆️
instrumentations-instrumentation-fs 32.00% <ø> (+0.01%) ⬆️
instrumentations-instrumentation-generic-pool 29.46% <ø> (+0.11%) ⬆️
instrumentations-instrumentation-http 39.99% <ø> (+0.08%) ⬆️
instrumentations-instrumentation-knex 32.39% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-mongoose 33.51% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-multer 40.38% <ø> (+0.08%) ⬆️
instrumentations-instrumentation-mysql2 38.40% <ø> (+0.07%) ⬆️
instrumentations-instrumentation-passport 44.16% <ø> (+0.10%) ⬆️
instrumentations-instrumentation-passport-http 43.84% <ø> (+0.09%) ⬆️
instrumentations-instrumentation-passport-local 44.37% <ø> (+0.10%) ⬆️
instrumentations-instrumentation-pg 37.84% <ø> (+0.06%) ⬆️
instrumentations-instrumentation-promise 32.25% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-promise-js 32.26% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-q 32.30% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-url 32.22% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-when 32.27% <ø> (+0.02%) ⬆️
llmobs-ai 41.61% <ø> (-0.86%) ⬇️
llmobs-anthropic 40.84% <ø> (+0.36%) ⬆️
llmobs-bedrock 39.32% <ø> (+0.06%) ⬆️
llmobs-google-genai 39.87% <ø> (+0.07%) ⬆️
llmobs-langchain 39.45% <ø> (-0.71%) ⬇️
llmobs-openai 44.12% <ø> (+0.13%) ⬆️
llmobs-vertex-ai 40.13% <ø> (+0.07%) ⬆️
platform-core 31.47% <ø> (ø)
platform-esbuild 34.42% <ø> (ø)
platform-instrumentations-misc 34.11% <ø> (-14.30%) ⬇️
platform-shimmer 37.56% <ø> (ø)
platform-unit-guardrails 32.89% <ø> (ø)
platform-webpack 19.96% <ø> (-0.02%) ⬇️
plugins-azure-durable-functions 25.74% <ø> (ø)
plugins-azure-event-hubs 25.90% <ø> (ø)
plugins-azure-service-bus 25.26% <ø> (ø)
plugins-bullmq 43.61% <ø> (-0.76%) ⬇️
plugins-cassandra 38.02% <ø> (+0.19%) ⬆️
plugins-cookie 26.96% <ø> (ø)
plugins-cookie-parser 26.75% <ø> (ø)
plugins-crypto 26.73% <ø> (ø)
plugins-dd-trace-api 38.43% <ø> (+0.06%) ⬆️
plugins-express-mongo-sanitize 26.89% <ø> (ø)
plugins-express-session 26.70% <ø> (ø)
plugins-fastify 42.36% <ø> (+0.09%) ⬆️
plugins-fetch 38.51% <ø> (+0.06%) ⬆️
plugins-fs 38.75% <ø> (+0.06%) ⬆️
plugins-generic-pool 25.94% <ø> (ø)
plugins-google-cloud-pubsub 45.69% <ø> (+0.11%) ⬆️
plugins-grpc 41.01% <ø> (+0.07%) ⬆️
plugins-handlebars 26.94% <ø> (ø)
plugins-hapi 40.27% <ø> (+0.08%) ⬆️
plugins-hono 40.61% <ø> (+0.08%) ⬆️
plugins-ioredis 38.60% <ø> (+0.10%) ⬆️
plugins-knex 26.57% <ø> (ø)
plugins-langgraph 37.99% <ø> (-0.56%) ⬇️
plugins-ldapjs 24.43% <ø> (ø)
plugins-light-my-request 26.30% <ø> (ø)
plugins-limitd-client 32.60% <ø> (+0.02%) ⬆️
plugins-lodash 26.03% <ø> (ø)
plugins-mariadb 39.61% <ø> (+0.08%) ⬆️
plugins-memcached 38.34% <ø> (+0.10%) ⬆️
plugins-microgateway-core 39.34% <ø> (+0.07%) ⬆️
plugins-moleculer 40.63% <ø> (+0.08%) ⬆️
plugins-mongodb 39.27% <ø> (+0.07%) ⬆️
plugins-mongodb-core 39.12% <ø> (+0.07%) ⬆️
plugins-mongoose 38.92% <ø> (+<0.01%) ⬆️
plugins-multer 26.70% <ø> (ø)
plugins-mysql 39.45% <ø> (+0.22%) ⬆️
plugins-mysql2 39.40% <ø> (+0.07%) ⬆️
plugins-node-serialize 27.00% <ø> (ø)
plugins-opensearch 37.74% <ø> (+0.06%) ⬆️
plugins-passport-http 26.76% <ø> (ø)
plugins-postgres 35.57% <ø> (+<0.01%) ⬆️
plugins-process 26.73% <ø> (ø)
plugins-pug 26.96% <ø> (ø)
plugins-redis 39.04% <ø> (+0.07%) ⬆️
plugins-router 43.36% <ø> (+0.10%) ⬆️
plugins-sequelize 25.55% <ø> (ø)
plugins-test-and-upstream-amqp10 38.62% <ø> (+0.07%) ⬆️
plugins-test-and-upstream-amqplib 44.37% <ø> (+0.12%) ⬆️
plugins-test-and-upstream-apollo 39.24% <ø> (+0.06%) ⬆️
plugins-test-and-upstream-avsc 38.69% <ø> (+0.07%) ⬆️
plugins-test-and-upstream-bunyan 33.93% <ø> (+0.03%) ⬆️
plugins-test-and-upstream-connect 40.93% <ø> (+0.08%) ⬆️
plugins-test-and-upstream-graphql 40.28% <ø> (+0.08%) ⬆️
plugins-test-and-upstream-koa 40.52% <ø> (+0.08%) ⬆️
plugins-test-and-upstream-protobufjs 38.92% <ø> (+0.07%) ⬆️
plugins-test-and-upstream-rhea 44.40% <ø> (+0.11%) ⬆️
plugins-undici 39.36% <ø> (+0.20%) ⬆️
plugins-url 26.73% <ø> (ø)
plugins-valkey 38.31% <ø> (+0.10%) ⬆️
plugins-vm 26.73% <ø> (ø)
plugins-winston 34.26% <ø> (+0.17%) ⬆️
plugins-ws 42.12% <ø> (+0.09%) ⬆️
profiling-macos 40.65% <ø> (+0.08%) ⬆️
profiling-ubuntu 40.78% <ø> (+0.08%) ⬆️
profiling-windows 42.30% <ø> (+0.47%) ⬆️
serverless-azure-functions-client 25.62% <ø> (ø)
serverless-azure-functions-eventhubs 25.62% <ø> (ø)
serverless-azure-functions-servicebus 25.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 30, 2026

Overall package size

Self size: 5.46 MB
Deduped: 6.3 MB
No deduping: 6.3 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.0.0 | 81.15 kB | 815.98 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-official
Copy link
Copy Markdown

datadog-official bot commented Mar 30, 2026

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 68.73% (-0.12%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7458570 | Docs | Datadog PR Page | Was this helpful? React with 👍/👎 or give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter bot commented Mar 30, 2026

Benchmarks

Benchmark execution time: 2026-04-03 19:09:53

Comparing candidate commit 7458570 in PR branch ida613/code-review-skill-new with baseline commit edb4236 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 234 metrics, 26 unstable metrics.

@ida613 ida613 requested a review from a team April 1, 2026 13:35
Copy link
Copy Markdown
Contributor

@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid! Do you have any examples of this working in practice?

Also, if you haven't already, you could run this through Anthropic's skill-creator skill to get additional feedback on it and evals against it. Just keep in mind that Anthropic's skill isn't fully deterministic so it may give conflicting results

Improved from PR #7888: description is explicit about trigger phrases,
SKILL.md body is lean (no checklist duplication), checklist is in
references/ per skill anatomy conventions, and gh pr diff is the
preferred method for fetching PR content.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ida613
Copy link
Copy Markdown
Collaborator Author

ida613 commented Apr 3, 2026

Looks solid! Do you have any examples of this working in practice?

Also, if you haven't already, you could run this through Anthropic's skill-creator skill to get additional feedback on it and evals against it. Just keep in mind that Anthropic's skill isn't fully deterministic so it may give conflicting results

Thank you Brian! I used it to review my own PR, and while I don't think it can replace human reviews, it did gave some good feedbacks.

I just pushed a commit using skill-creator, thank you for the rec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants