Skip to content

Allow fallback parser to skip comments in unknown IF_DATA blocks#48

Merged
DanielT merged 1 commit intoDanielT:mainfrom
AkhilTThomas:fix-commnet-handling
Feb 22, 2026
Merged

Allow fallback parser to skip comments in unknown IF_DATA blocks#48
DanielT merged 1 commit intoDanielT:mainfrom
AkhilTThomas:fix-commnet-handling

Conversation

@AkhilTThomas
Copy link
Copy Markdown
Contributor

The fallback IF_DATA parser crashes with "/begin in block ... is not followed by a valid tag" when it encounters block comments (/* ... */) or line comments (// ...) inside an IF_DATA block.

This used to work at least in the a2ltool version 2.4.0.

The PR fixes it enables back the parsing of comments between unknown tagged struct block.

@DanielT
Copy link
Copy Markdown
Owner

DanielT commented Feb 22, 2026

Good catch! Thanks for the fix.
I also appreciate that you added a test for the problem.

@DanielT DanielT merged commit 99fe143 into DanielT:main Feb 22, 2026
1 of 2 checks passed
@AkhilTThomas
Copy link
Copy Markdown
Contributor Author

Good catch! Thanks for the fix.
I also appreciate that you added a test for the problem.

How often is the a2ltool released?
I'd appreciate if there is a new release using these changes 😃

@DanielT
Copy link
Copy Markdown
Owner

DanielT commented Feb 22, 2026

How often is the a2ltool released?

Whenever there are features / fixes to release, and I find time to do so :-)
I almost did it yesterday, since there is already a fix from louiscaron that I also want to release, but then other stuff came up.
So the next release will be soon(ish).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants