Allow fallback parser to skip comments in unknown IF_DATA blocks#48
Merged
DanielT merged 1 commit intoDanielT:mainfrom Feb 22, 2026
Merged
Allow fallback parser to skip comments in unknown IF_DATA blocks#48DanielT merged 1 commit intoDanielT:mainfrom
DanielT merged 1 commit intoDanielT:mainfrom
Conversation
Owner
|
Good catch! Thanks for the fix. |
Contributor
Author
How often is the a2ltool released? |
Owner
Whenever there are features / fixes to release, and I find time to do so :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fallback IF_DATA parser crashes with "/begin in block ... is not followed by a valid tag" when it encounters block comments (/* ... */) or line comments (// ...) inside an IF_DATA block.
This used to work at least in the a2ltool version 2.4.0.
The PR fixes it enables back the parsing of comments between unknown tagged struct block.