Fix uncaught exception when sorting columns in Graph Summary#111
Open
Olipro wants to merge 1 commit intoDanielKote:Mainfrom
Open
Fix uncaught exception when sorting columns in Graph Summary#111Olipro wants to merge 1 commit intoDanielKote:Mainfrom
Olipro wants to merge 1 commit intoDanielKote:Mainfrom
Conversation
The callback responsible for sorting columns would assume that the Tag field of the control always held a `DataObjectBase` but this is not necessarily true. We now safely check if the type is compatible to avoid an uncaught exception. Additionally, I have added code that will make a final attempt to sort by quality level; though I'm not entirely clear if it actually makes sense to do so here. If not, please let me know and I can alter/remove it. fixes DanielKote#106
Olipro
force-pushed
the
GraphSummaryCrashFix
branch
from
74339c9 to
6481db1
Compare
Collaborator
Author
|
I would mention that I did investigate having |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The callback responsible for sorting columns would assume that the Tag field of the control always held a
DataObjectBasebut this is not necessarily true.We now safely check if the type is compatible to avoid an uncaught exception.
Additionally, I have added code that will make a final attempt to sort by quality level; though I'm not entirely clear if it actually makes sense to do so here. If not, please let me know and I can alter/remove it.
fixes #106