Added branch merging protection + Linting rules#1
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a standardized linting and formatting setup across the repository and enforces a strict branch merge flow via a GitHub Actions workflow.
- Adds ESLint, Prettier, and related scripts to
package.json - Introduces a centralized
eslint.config.jsand editor settings for automatic formatting - Implements a GitHub workflow to auto-label, comment on, and close PRs that violate the
main→testnet→mainnetmerge sequence
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Added lint/format scripts and moved TypeScript to deps |
| eslint.config.js | New ESLint configuration with SolidJS and TypeScript rules |
| .zed/settings.json | Editor settings for on-save Prettier + ESLint fixes |
| .prettierrc.json | Base Prettier configuration |
| .prettierignore | Files/directories to exclude from Prettier formatting |
| .github/workflows/merge_protection.yml | Workflow enforcing branch protection rules |
Comments suppressed due to low confidence (4)
.github/workflows/merge_protection.yml:25
- Multi-line output into
$GITHUB_OUTPUTmust use the GitHub Actions multiline syntax (e.g.,echo "message<<EOF" >> $GITHUB_OUTPUTfollowed by the body andEOF). Otherwise, newlines can break output parsing.
echo "message=❌ **Branch Protection Violation**
.github/workflows/merge_protection.yml:1
- There are no automated tests for the branch protection workflow logic. Consider adding CI validation (e.g., using
actor Actions tests) to simulate PR events and ensure the checks behave as expected.
name: Branch Protection Enforcement
package.json:38
- TypeScript is typically a dev dependency. Consider moving it from
dependenciesback intodevDependenciesto avoid shipping it in production bundles.
"typescript": "^5.8.3",
eslint.config.js:45
- The
@typescript-eslint/interface-name-prefixand@typescript-eslint/prefer-interfacerules have been removed in recent versions of the plugin and will cause ESLint to error. You should delete these entries or replace them with equivalent naming-convention settings.
"@typescript-eslint/interface-name-prefix": "off",
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains #feat/linting-rules included. It focuses on adding base level logic to the overall repository to ensure consistency when deploying and building the codebase in the future.
The changes included in this PR are:
main->testnet->mainnetflow it is automatically labeled, closed and flagged for attention. The user that makes the PR will receive a message within the closed PR mentioning that the PR broke branch protection rules and to follow the overall deployment flow appropriately.