Add ability to delete bundles in file administration#5307
Open
alijaber-atmire wants to merge 26 commits intoDSpace:mainfrom
Open
Add ability to delete bundles in file administration#5307alijaber-atmire wants to merge 26 commits intoDSpace:mainfrom
alijaber-atmire wants to merge 26 commits intoDSpace:mainfrom
Conversation
- Introduced 'setFields' method - Applied more consistency in using fields vs parameters in methods - Split up methods related to iiif
Splitting the creation of the form into multiple methods that do one specific thing (e.g. updating the form model, creating the form group, prefilling data in the form, ...) allows for easier theming of the form itself.
Without this fix the form showed old data when immediately going back to the edit page after changing the primary bitstream or format.
Moved the creation of the update observables to their own methods and unified the handling of their results in a single subscription
…age-refactor-9.0 # Conflicts: # src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.html # src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.spec.ts # src/app/bitstream-page/edit-bitstream-page/edit-bitstream-page.component.ts
… fixes Replaced remaining ItemService#getBundles usages with BundleService#findAllByItem because the first one didn't use caching
…bute-7.6' into w2p-138875_ability-to-delete-bundles-in-file-administration-ANGULAR-main
# Conflicts: # src/app/core/data/item-data.service.ts # src/app/item-page/edit-item-page/item-bitstreams/item-edit-bitstream-bundle/item-edit-bitstream-bundle.component.html
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
Adds bundle-level delete on the item Edit bitstreams page: curators can mark a whole bundle for removal, undo before save, and submit so the UI removes bundles (and their bitstreams) through the REST API. Bundle loading and submit flow are aligned with
BundleDataServiceand cache invalidation so the list refreshes after deletes.Instructions for Reviewers
List of changes in this PR:
ItemBitstreamsService.removeMarkedBundlesAndBitstreamsissues bulk bundle removal (JSON Patchremoveoperations on/bundles/{id}viaBundleDataService.removeMultiple) alongside existing bitstream deletions; success/error notifications distinguish bundles-only, bitstreams-only, or both.BundleDataService.removeMultiplesends the patch to the bundles collection endpoint; item bitstreams page usesBundleDataService.findAllByItemfor bundle lists and invalidates the item’s bundles link after successful saves.How to test / review
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.