Dataset-saving infrastructure phase 1#688
Open
SolarDrew wants to merge 29 commits intoDKISTDC:mainfrom
Open
Conversation
Contributor
Author
|
I'm sure there are other issues remaining but the bulk of the current error are due to slicing bugs in |
SolarDrew
force-pushed
the
filesaving
branch
from
397b1de to
7aca21a
Compare
Contributor
Author
We can remove this if and when we figure out why it's happening
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Until I can make the example work
Cadair
requested changes
Mar 9, 2026
Member
Cadair
left a comment
Cadair
left a comment
There was a problem hiding this comment.
(Blocking because of git dependency)
| "asdf-astropy>=0.5.0", # Required by gwcs 0.24 | ||
| "asdf-coordinates-schemas>=0.3.0", # required by wcs-schemas 0.4 | ||
| "asdf>=4.0.0", # Required by gwcs 0.24 | ||
| "asdf-astropy@git+https://github.com/Cadair/asdf-astropy@highlevelwcswrapper", # Required for dataset.save() |
Member
There was a problem hiding this comment.
This needs changing before merging.
| Dataset loading and saving routines. | ||
| """ | ||
|
|
||
| def save(self, asdf_path=None, basepath=None, overwrite=False): |
Member
There was a problem hiding this comment.
I wonder if 3 .save() methods is better than dkist.io.save(anything_here)?
| Dataset loading and saving routines. | ||
| """ | ||
|
|
||
| def save(self, asdf_path=None, basepath=None, overwrite=False): |
Member
There was a problem hiding this comment.
I feel like defaulting to "put new asdf where old one is" is a curious choice? why don't we make asdf_path required? then we can also drop the base_path kwarg?
Co-authored-by: Stuart Mumford <stuart@cadair.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #671