Conversation
Contributor
|
Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability. Example:
Projects:
Please add a Jira issue key to your PR title. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
services/apps/git_integration/src/crowdgit/services/maintainer/maintainer_service.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the maintainer file detection logic in the
MaintainerServiceby broadening the list of recognized maintainer-related files and improving howREADME.mdfiles are handled. The main goal is to make maintainer identification more accurate and robust.Improvements to maintainer file detection:
GOVERNANCE.md,README.md, andSECURITY-INSIGHTS.mdin addition to existing files.README.mdfiles that do not contain maintainer-related content, reducing false positives when searching for maintainer information.Note
Medium Risk
Changes maintainer-file selection logic, which can alter which repositories yield maintainer data and may inadvertently skip valid README-based ownership info if it doesn’t contain the keyword check.
Overview
Improves maintainer file detection by expanding the known candidate list to include
GOVERNANCE.md,README.md, andSECURITY-INSIGHTS.md.Adds a guard to skip
README.mdwhen it doesn’t contain “maintainer” text, applying this both to direct filename matching and to AI-suggested files to reduce false positives.Written by Cursor Bugbot for commit 001cfa3. This will update automatically on new commits. Configure here.