Skip to content

feat: support extra maintainers files with specific check for readme.md [CM-1032]#3898

Merged
mbani01 merged 3 commits intomainfrom
feat/support_extra_maintainers_filename
Mar 6, 2026
Merged

feat: support extra maintainers files with specific check for readme.md [CM-1032]#3898
mbani01 merged 3 commits intomainfrom
feat/support_extra_maintainers_filename

Conversation

@mbani01
Copy link
Contributor

@mbani01 mbani01 commented Mar 6, 2026

This pull request enhances the maintainer file detection logic in the MaintainerService by broadening the list of recognized maintainer-related files and improving how README.md files are handled. The main goal is to make maintainer identification more accurate and robust.

Improvements to maintainer file detection:

  • Expanded the list of known maintainer files to include GOVERNANCE.md, README.md, and SECURITY-INSIGHTS.md in addition to existing files.
  • Updated the logic to skip README.md files that do not contain maintainer-related content, reducing false positives when searching for maintainer information.

Note

Medium Risk
Changes maintainer-file selection logic, which can alter which repositories yield maintainer data and may inadvertently skip valid README-based ownership info if it doesn’t contain the keyword check.

Overview
Improves maintainer file detection by expanding the known candidate list to include GOVERNANCE.md, README.md, and SECURITY-INSIGHTS.md.

Adds a guard to skip README.md when it doesn’t contain “maintainer” text, applying this both to direct filename matching and to AI-suggested files to reduce false positives.

Written by Cursor Bugbot for commit 001cfa3. This will update automatically on new commits. Configure here.

@mbani01 mbani01 self-assigned this Mar 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

⚠️ Jira Issue Key Missing

Your PR title doesn't contain a Jira issue key. Consider adding it for better traceability.

Example:

  • feat: add user authentication (CM-123)
  • feat: add user authentication (IN-123)

Projects:

  • CM: Community Data Platform
  • IN: Insights

Please add a Jira issue key to your PR title.

@mbani01 mbani01 changed the title feat: support extra maintainers files with specific check for readme.md feat: support extra maintainers files with specific check for readme.md [CM-1032] Mar 6, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@mbani01 mbani01 merged commit 77767fa into main Mar 6, 2026
14 checks passed
@mbani01 mbani01 deleted the feat/support_extra_maintainers_filename branch March 6, 2026 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant