Skip to content

Replace look with lookText' in controller modules#1679

Open
Purplegaze wants to merge 10 commits intoCourseography:masterfrom
Purplegaze:controller-looktext
Open

Replace look with lookText' in controller modules#1679
Purplegaze wants to merge 10 commits intoCourseography:masterfrom
Purplegaze:controller-looktext

Conversation

@Purplegaze
Copy link
Contributor

@Purplegaze Purplegaze commented Mar 17, 2026

Proposed Changes

Replaces look with lookText in Controllers/Graph and Controllers/Timetable.

BC.pack is replaced with TE.encodeUtf8 in a related function; this is backwards compatible since BC.pack works on ASCII and all ASCII is valid UTF8.

...

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).
    • I think this can be considered part of the "Refactored various backend functions to use Text instead of String" line that's already in the changelog for this update

After opening your pull request:

  • I have verified that the CircleCI checks have passed.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls
Copy link

Pull Request Test Coverage Report for Build f62b14df-2719-4a15-a9db-973c1de81d2c

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Controllers/Graph.hs 0 1 0.0%
app/Export/GetImages.hs 0 1 0.0%
Totals Coverage Status
Change from base Build ac1c0723-45d7-45be-8bea-efc2c6525e84: 0.0%
Covered Lines: 2280
Relevant Lines: 3956

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants