feat: apply proxy settings to Electron, Python, and child processes#1679
Draft
feat: apply proxy settings to Electron, Python, and child processes#1679
Conversation
Read Comfy.Network.Proxy.* settings from comfy.settings.json on startup: - Configure Chromium via session.defaultSession.setProxy() - Set process.env HTTP_PROXY/HTTPS_PROXY/NO_PROXY for child processes - Inject --http-proxy/--https-proxy/--no-proxy into Python server args - Forward proxy env vars to uv PTY sessions for pip/package installs Ref: #1105 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… proxies
- Redact embedded credentials from proxy URLs before logging to prevent
secrets from leaking into log files and Sentry crash reports.
- Build proper Chromium per-scheme proxy rules ("http=X;https=Y") when
both HTTP and HTTPS proxies are configured, instead of collapsing them.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comfy.Network.Proxy.*settings fromcomfy.settings.jsonon app startupsession.defaultSession.setProxy()for Electron's own networkprocess.envHTTP_PROXY/HTTPS_PROXY/NO_PROXYfor all child processes--http-proxy/--https-proxy/--no-proxyinto Python server launch argsPart of a cross-repo feature. Related PRs:
Ref: #1105
Test plan
--http-proxyarg🤖 Generated with Claude Code
┆Issue is synchronized with this Notion page by Unito