Skip to content

feat: apply proxy settings to Electron, Python, and child processes#1679

Draft
snomiao wants to merge 5 commits intomainfrom
sno-proxysettings
Draft

feat: apply proxy settings to Electron, Python, and child processes#1679
snomiao wants to merge 5 commits intomainfrom
sno-proxysettings

Conversation

@snomiao
Copy link
Copy Markdown
Member

@snomiao snomiao commented Mar 26, 2026

Summary

  • Read Comfy.Network.Proxy.* settings from comfy.settings.json on app startup
  • Configure Chromium via session.defaultSession.setProxy() for Electron's own network
  • Set process.env HTTP_PROXY/HTTPS_PROXY/NO_PROXY for all child processes
  • Inject --http-proxy/--https-proxy/--no-proxy into Python server launch args
  • Forward proxy env vars to uv PTY sessions for pip/package installs

Part of a cross-repo feature. Related PRs:

  • Comfy-Org/ComfyUI — backend CLI args + env var setup
  • Comfy-Org/ComfyUI_frontend — proxy settings UI

Ref: #1105

Test plan

  • Set proxy URL in Settings > Comfy > Network, restart app
  • Verify Python server receives --http-proxy arg
  • Verify Electron BrowserWindow routes through proxy
  • Verify uv/pip operations use proxy during package installs
  • No proxy configured = no behavior change

🤖 Generated with Claude Code

┆Issue is synchronized with this Notion page by Unito

Read Comfy.Network.Proxy.* settings from comfy.settings.json on startup:
- Configure Chromium via session.defaultSession.setProxy()
- Set process.env HTTP_PROXY/HTTPS_PROXY/NO_PROXY for child processes
- Inject --http-proxy/--https-proxy/--no-proxy into Python server args
- Forward proxy env vars to uv PTY sessions for pip/package installs

Ref: #1105

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 26, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: db10fa9b-470a-4144-88c4-b925c49e7e4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sno-proxysettings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

snomiao and others added 4 commits March 29, 2026 04:19
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… proxies

- Redact embedded credentials from proxy URLs before logging to prevent
  secrets from leaking into log files and Sentry crash reports.
- Build proper Chromium per-scheme proxy rules ("http=X;https=Y") when
  both HTTP and HTTPS proxies are configured, instead of collapsing them.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant