Skip to content

bug: remove title validation from event type form#3

Closed
devin-ai-integration[bot] wants to merge 1 commit intostagingfrom
workshop/bug-validation
Closed

bug: remove title validation from event type form#3
devin-ai-integration[bot] wants to merge 1 commit intostagingfrom
workshop/bug-validation

Conversation

@devin-ai-integration
Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot commented Jan 8, 2026

What does this PR do?

Removes the minimum length validation (.min(1)) from the title field in event type Zod schemas, allowing empty titles to be accepted when creating, duplicating, or updating event types.

⚠️ Note: This change intentionally removes validation and may be for workshop/testing purposes based on the branch name.

Changes:

  • packages/features/eventtypes/lib/schemas.ts: Removed .min(1) from EventTypeDuplicateInput and createEventTypeInput
  • packages/trpc/server/routers/viewer/eventTypes/types.ts: Removed .min(1) from BaseEventTypeUpdateInput
  • apps/web/modules/event-types/components/DuplicateDialog.tsx: Removed .min(1) from query schema

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Navigate to Event Types page
  2. Try to create a new event type with an empty title
  3. Verify the form now accepts empty titles (previously would show validation error)
  4. Try duplicating an event type and clear the title field
  5. Try updating an existing event type with an empty title

Human Review Checklist

  • Verify this change is intentional (branch name suggests workshop/testing purpose)
  • Check if database schema allows empty titles or if this will cause runtime errors
  • Consider downstream effects of empty event type titles in UI/booking pages

Link to Devin run: https://partner-workshops.devinenterprise.com/sessions/f8123587dc3d4f0eac9c02dd561b3e6d
Smitches ()

@devin-ai-integration
Copy link
Copy Markdown
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 6, 2026

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "bug" found in pull request title "bug: remove title validation from event type form". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants