bug: use include instead of select in bookings query#2
Closed
devin-ai-integration[bot] wants to merge 1 commit intostagingfrom
Closed
bug: use include instead of select in bookings query#2devin-ai-integration[bot] wants to merge 1 commit intostagingfrom
devin-ai-integration[bot] wants to merge 1 commit intostagingfrom
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies the bookings query handler to use
selectAll()instead of selecting specific user fields when fetching user data associated with bookings.Change: In
packages/trpc/server/routers/viewer/bookings/get.handler.ts, the Kysely query that fetches user data now uses.selectAll()instead of explicitly selectingid,name,email,avatarUrl,username, andtimeZone.This change exposes ALL user fields in the API response, including potentially sensitive fields that were previously filtered out. The original code intentionally selected only safe fields to return.
Reviewers should verify:
userstable will now be included in responsesMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Link to Devin run: https://partner-workshops.devinenterprise.com/sessions/7ea2b981b4d44c14bead9e1d51446a35
Smitches ()