vuln: remove admin role check#10
Closed
devin-ai-integration[bot] wants to merge 1 commit intostagingfrom
Closed
Conversation
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR comments out the admin role authorization check in
isAdminMiddleware, allowing any authenticated user to access admin-only endpoints.Changes
The
isAdminMiddlewareinpackages/trpc/server/middlewares/sessionMiddleware.tsno longer verifies thatuser.role === "ADMIN"before allowing access to protected admin routes.Affected endpoints include:
admin.listPaginated- List all usersadmin.sendPasswordReset- Send password reset emailsadmin.lockUserAccount- Lock user accountsadmin.removeTwoFactor- Remove 2FA from accountsadmin.setSMSLockState- Control SMS lock stateadmin.createSelfHostedLicense- Create license keysVisual Demo (For contributors especially)
N/A - This is a code-only change for workshop demonstration.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
admin.listPaginated)Human Review Checklist
Link to Devin run: https://partner-workshops.devinenterprise.com/sessions/eca82cdf00064dc0b0b9e4b4f3d037ce