Fix #135: Add Minesweeper model

[isPANN]

Summary

• Add the Minesweeper Consistency problem as a SatisfactionProblem in src/models/misc/
• Implements grid-based constraint satisfaction where revealed cells constrain adjacent unrevealed cells
• Includes CLI support (pred create Minesweeper), unit tests, and example program

Fixes #135

[codecov]

Codecov Report

❌ Patch coverage is 99.53917% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 96.51%. Comparing base (0ac50ca) to head (da96540).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/models/misc/minesweeper.rs	99.15%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
+ Coverage   96.49%   96.51%   +0.02%     
==========================================
  Files         204      206       +2     
  Lines       28397    28614     +217     
==========================================
+ Hits        27401    27617     +216     
- Misses        996      997       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[isPANN]

Implementation Summary

Changes

• src/models/misc/minesweeper.rs — New model implementing SatisfactionProblem with grid-based constraint checking
• src/unit_tests/models/misc/minesweeper.rs — 8 unit tests covering creation, evaluation (satisfiable + unsatisfiable), serialization, solver integration, and variant checks
• examples/minesweeper_consistency.rs — Example using a 3×3 classic pattern instance
• problemreductions-cli/src/dispatch.rs — CLI load/serialize dispatch
• problemreductions-cli/src/problem_name.rs — Alias registration
• problemreductions-cli/src/cli.rs — New --rows, --cols, --revealed flags
• problemreductions-cli/src/commands/create.rs — pred create Minesweeper support with auto-computed unrevealed cells
• Registration in mod.rs, lib.rs, tests/suites/examples.rs

Deviations from Plan

• Added stronger constructor validation (overlap detection, count <= 8, duplicate detection) based on review feedback
• Added config.len() guard in evaluate() for defensive programming

Open Questions

• Paper entries (display-name and problem-def) not yet added — these are handled by the separate write-model-in-paper skill

[Copilot]

Pull request overview

Adds a new “Minesweeper Consistency” satisfaction problem model to the problemreductions library, wires it into the public exports and CLI, and provides an example + tests to exercise the new model end-to-end.

Changes:

• Introduce Minesweeper as a new SatisfactionProblem model (schema registration, variants, evaluation logic) plus unit tests.
• Integrate Minesweeper into the CLI (name aliasing, JSON dispatch load/serialize, pred create flags) and document flags.
• Add a runnable example and include it in the examples test suite.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
tests/suites/examples.rs	Adds the new Minesweeper example to the examples test harness.
src/unit_tests/models/misc/minesweeper.rs	New unit tests covering construction, evaluation, serialization, and brute-force solving.
src/models/mod.rs	Re-exports Minesweeper at the models module level.
src/models/misc/mod.rs	Registers the new misc model module and re-export.
src/models/misc/minesweeper.rs	Implements the Minesweeper problem model and registers schema/variants.
src/lib.rs	Exposes Minesweeper via the crate prelude.
problemreductions-cli/src/problem_name.rs	Adds minesweeper alias resolution to canonical Minesweeper.
problemreductions-cli/src/dispatch.rs	Enables CLI JSON load/serialize support for Minesweeper.
problemreductions-cli/src/commands/create.rs	Adds CLI instance creation for Minesweeper and parsing for --revealed.
problemreductions-cli/src/cli.rs	Documents Minesweeper flags and adds --rows/--cols/--revealed to CLI args.
examples/minesweeper_consistency.rs	New example demonstrating satisfiability solving for a classic pattern.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

evaluate() rebuilds a HashMap from position→index on every call. This is particularly expensive with BruteForce, which may call evaluate() O(2^n) times, turning the solve into O(2^n * n) extra hashing work. Consider precomputing/caching the position→index mapping (or per-revealed-cell neighbor index lists) once during construction (and reconstructing after deserialization if needed) so that evaluate() only does cheap indexed lookups.

[Copilot]

The CLI create path relies on Minesweeper::new() assertions for validation (bounds, duplicates, overlaps, count<=8). If a user passes invalid --revealed coordinates or duplicates, the CLI will panic instead of returning a structured error. Prefer validating revealed in the CLI (bounds check against rows/cols, duplicate positions) and returning a bail!(...)/anyhow!(...) error before calling Minesweeper::new().