Skip to content

feat: add color pallets#1294

Merged
HardeepAsrani merged 3 commits intodevelopmentfrom
feat/issue-539
Mar 30, 2026
Merged

feat: add color pallets#1294
HardeepAsrani merged 3 commits intodevelopmentfrom
feat/issue-539

Conversation

@HardeepAsrani
Copy link
Copy Markdown
Member

@HardeepAsrani HardeepAsrani commented Mar 26, 2026

Summary

This PR adds a Color Presets settings page. A palette made from these primary/secondary combo is applied to all classic chart types as default (except Geo).

Failing e2e tests are unrelated. They will be fixed separately.

Will affect visual aspect of the product

YES/NO

Screenshots

Test instructions

  • Make sure new charts inherit the presets while old charts remain untoucehd.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/visualizer-pro/issues/539.

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 26, 2026
@HardeepAsrani HardeepAsrani marked this pull request as ready for review March 26, 2026 19:50
@pirate-bot
Copy link
Copy Markdown
Contributor

pirate-bot commented Mar 26, 2026

Plugin build for 3212b38 is ready 🛎️!

@rodica-andronache
Copy link
Copy Markdown
Contributor

@HardeepAsrani it's working well. It's possible to also add the checkbox to apply it to existing charts?

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 27, 2026
@rodica-andronache
Copy link
Copy Markdown
Contributor

@HardeepAsrani, when clicking on the "Clear" button, the charts should revert to their normal styling
image

@HardeepAsrani
Copy link
Copy Markdown
Member Author

@HardeepAsrani, when clicking on the "Clear" button, the charts should revert to their normal styling

@rodica-andronache That's exactly what happens once you click on Clear and save the settings. They go back to their original.

Keep in mind that behavior only works for Apply to Existing blocks. If you created a new block, those colors are saved to the block. As at a future point in time, we have no way to know if the user picked a particular shade of red as a preset or manually.

Makes sense?

@rodica-andronache
Copy link
Copy Markdown
Contributor

@HardeepAsrani ok, it makes sense. We can merge this

@HardeepAsrani HardeepAsrani merged commit 641601c into development Mar 30, 2026
9 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/issue-539 branch March 30, 2026 10:46
@pirate-bot
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants