Skip to content

London | JAN-ITP-26 | Kayanat Suleman | Sprint 3 | Alarm Clock App #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KayanatSuleman wants to merge 9 commits into
base: main
Choose a base branch
from
Open

London | JAN-ITP-26 | Kayanat Suleman | Sprint 3 | Alarm Clock App #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ddb79fc
Updating index.html - with an accurate title
KayanatSuleman Feb 26, 2026
61fe419
Alarm clock: display entered time in mm:ss format
KayanatSuleman Feb 27, 2026
7cafbef
Alarm clock: start timer with setInterval every 1000ms
KayanatSuleman Feb 27, 2026
6b24f06
Alarm clock: decrement and update heading each second
KayanatSuleman Feb 27, 2026
eb90347
Alarm clock: play alarm and stop timer at 00:00
KayanatSuleman Feb 27, 2026
5d17875
Updating the app as per the review comments
KayanatSuleman Mar 4, 2026
2177f21
Testing the UI with a message
KayanatSuleman Mar 5, 2026
75dc638
Adding a user message for positive int input
KayanatSuleman Mar 5, 2026
8a454bf
Adding validation messages and preventing negative input from user
KayanatSuleman Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 49 additions & 1 deletion Sprint-3/alarmclock/alarmclock.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,52 @@
function setAlarm() {}
let intervalId = null;

function formatTime(totalSeconds) {
const minutes = Math.floor(totalSeconds / 60);
const seconds = totalSeconds % 60;

const formattedMinutes = String(minutes).padStart(2, "0");
const formattedSeconds = String(seconds).padStart(2, "0");

return `${formattedMinutes}:${formattedSeconds}`;
}

function setAlarm() {
const input = document.getElementById("alarmSet");
const heading = document.getElementById("timeRemaining");

let value = input.value

if (value === "") {
heading.innerText = "Please enter a number of seconds.";
return;
Copy link

@A-O-Emmanuel A-O-Emmanuel Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of returning it will be better to show the user an appropriate message, can you think of a way to do that please.

Copy link
Author

@KayanatSuleman KayanatSuleman Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @A-O-Emmanuel, thank you for the review comments. I have updated the validation so that if the input field is empty, the app now displays a user message ("Please enter a number of seconds.") instead of returning silently. This prevents the timer from starting without valid input.

}

let remainingSeconds = Number(value);

if (remainingSeconds <= 0 || isNaN(remainingSeconds)) {
heading.innerText = "Please enter a positive number greater than 0.";
return;
Copy link

@A-O-Emmanuel A-O-Emmanuel Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also instead of returning, it will be better you show the user an appropriate message, think of a way to do that.

Copy link
Author

@KayanatSuleman KayanatSuleman Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review comment. I have now updated the logic so that if the value is invalid (NaN) or less than or equal to zero, the app displays the message ("Please enter a positive number greater than 0.") rather than returning silently.

}

heading.innerText = `Time Remaining: ${formatTime(remainingSeconds)}`;

if (intervalId !== null) {
clearInterval(intervalId);
}

intervalId = setInterval(() => {
remainingSeconds -= 1;

if (remainingSeconds <= 0) {
heading.innerText = `Time Remaining: ${formatTime(0)}`;
playAlarm();
clearInterval(intervalId);
intervalId = null;
return;
}
heading.innerText = `Time Remaining: ${formatTime(remainingSeconds)}`;
}, 1000);
}

// DO NOT EDIT BELOW HERE

Expand Down
4 changes: 2 additions & 2 deletions Sprint-3/alarmclock/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
<meta charset="utf-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<link rel="stylesheet" href="style.css" />
<title>Title here</title>
<title>Alarm Clock App</title>
</head>
<body>
<div class="centre">
<h1 id="timeRemaining">Time Remaining: 00:00</h1>
<label for="alarmSet">Set time to:</label>
<input id="alarmSet" type="number" />
<input id="alarmSet" type="number" min="1" step="1"/>

<button id="set" type="button">Set Alarm</button>
<button id="stop" type="button">Stop Alarm</button>
Expand Down