Merge pull request #19 from CodeByMAB/main#20
Merged
Conversation
Merge pull request #18 from CodeByMAB/feature/mvp-bxs-pipeline
…er spec structure - Fixed config_spec.yaml to use version 2 format with spec.type: object - Changed number field ranges from strings to arrays (e.g., [0, 100] not "[0, 100]") - Ensured all properties are under spec.properties - Added additionalProperties: false to spec - Fixed 'Couldn't convert output to correct type' RPC error - Updated embassy.js getConfig to synchronous function - Re-added config-spec.yaml to assets in manifest.yaml
- Fixed ruff linting errors (unused imports, f-strings without placeholders) - Applied black formatting to 4 files - All linting and formatting checks now pass
- Root endpoint now always returns JSON with 'endpoints' key - /metrics/latest now returns keys 'f', 'S', 'BXS' (mapped from DB columns) - f: from wallet.f - S: from blocks.S - BXS: from metrics.BXS_cum - Both endpoints use JSONResponse for consistent JSON output - Fixes test_root and test_metrics_latest failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge pull request #18 from CodeByMAB/feature/mvp-bxs-pipeline