fix: check the X-ClickHouse-Exception-Code for err code

[dermasmid]

Summary

use the X-ClickHouse-Exception-Code header ClickHouse/ClickHouse#8786

Related: #332 (similar issue can happen with inserts)

[slvrtrn]

fixes: #332

It does not fix it for select streaming, as the headers will already be received; this is only for inserts.

[dermasmid]

ok, so this solves a similar issue we had, should i open a separate issue for that?

[slvrtrn]

ok, so this solves a similar issue we had, should i open a separate issue for that?

No, this is fine. Thanks for the contribution!

[slvrtrn]

@dermasmid, is it possible to add an integration test for that? And one more question: in case of a CH error rejection, we usually return an instance of ClickHouseError. Is it the same when X-ClickHouse-Exception-Code is present in the response?

[dermasmid]

in theory the error should be parsed just fine, since it's using regex to find the error from the body:

clickhouse-js/packages/client-common/src/error/parse_error.ts

Line 2 in 00af5c2

/(Code|Error): (?<code>\d+).*Exception: (?<message>.+)\((?<type>(?=.+[A-Z]{3})[A-Z0-9_]+?)\)/s

ill try to get a test in too

[peter-leonov-ch]

@dermasmid, thanks a bunch for your contribution! We're ingesting the PR here:

• fix: check the X-ClickHouse-Exception-Code for err code #554