This repository was archived by the owner on Oct 14, 2022. It is now read-only.
Open
Conversation
Co-Authored-By: Tom Crockett <pelotom@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When validation fails, pass through the original
valueargument. Runtypes does give the message and key for the validation failure, however it does not (currently) pass through the original value argument, so there is not any introspection that can be done on it after failure without the original un-validated value. This is annoying because if one wants to do introspection after failure (e.g. null check) it would have to be done by passing in the runtypeResultand the originalany/unknownvalue.It would be dangerous to allow
SuccessandFailureto both have avaluekey because then one could call.valueon any type of result. IMO calling itvalueInvalidatedindicates that it does represent some sort of value but it should not be taken as checked data.