Merged
Conversation
This is required by Architectury Loom 1.7+
There are some *changes* changes, such as the removal of the "handleBlockBreakAck" packet handler as the packet no longer contains the block position. It probably doesn't matter though as block updates should be handled by the other packets. Another thing is the TODO now in the Cartography class as I am not certain that the behaviour is the same. May need some testing. Also removed the "xaeros-minimap" dependency as it's not used. There's a problem with the Forge client that I haven't been able to fix. It errors saying that the same package is being exported: "Modules MapSync.dev and generated_a20f2c1 export package gjum.minecraft.mapsync.common.data to module mixin.synthetic". No idea how to fix. Tempted to just switch to NeoForge.
- Packet size 2^15 -> 2^20 / 21 (~1MB) WORKING with VoxelMap
Updated README to include new features and clarify usage instructions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #114 for main PR