Implements US6909 (Blocking Tenants from IPv6 Usage) Primitive temporary disabling via the APIs#9
Open
lexholden wants to merge 4 commits intoCiscoSystems:cis-havanafrom
Open
Implements US6909 (Blocking Tenants from IPv6 Usage) Primitive temporary disabling via the APIs#9lexholden wants to merge 4 commits intoCiscoSystems:cis-havanafrom
lexholden wants to merge 4 commits intoCiscoSystems:cis-havanafrom
Conversation
|
If tests fail, the build system will fail the build and refuse to package it. Tests will need to be fixed too. |
|
Also, please have a look at: http://wikicentral.cisco.com/display/PROJECT/Commit+Message+Guidelines |
Author
|
OK - actually looking through the tests in the cis-havana branch, there are no IPV6 tests... In theory these should pass then, I was running them on a later version of havana because I've not been able to build devstack from the cis-havana branches... Every error I fix gives me several more. |
Author
|
And OK thanks, will change the commit message now. |
This reverts commit c18267e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inevitably this breaks the unit tests, since there are tests such as:
test_create_subnet_with_ipv6_address_mode
All this does is disallow 6 as a parameter when creating a subnet.
If we want to improve the UX of tenants we could add a custom message ("IPV6 Has been disabled for now") but figure this isn't important for now.