Add Gemini AI assist support (AST-127165)#1456
Open
cx-margarita-levitm wants to merge 4 commits intomainfrom
Open
Add Gemini AI assist support (AST-127165)#1456cx-margarita-levitm wants to merge 4 commits intomainfrom
cx-margarita-levitm wants to merge 4 commits intomainfrom
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
cx-rahul-pidde
requested changes
Mar 18, 2026
| } | ||
|
|
||
| this.logs.info(`[DEBUG] Final assistant type: ${assistantType}`); | ||
| this.logs.info(`[DEBUG] Extension ID: ${this.selectedChatExtensionId}`); |
Contributor
There was a problem hiding this comment.
Change log level from info to debug .
|
|
||
| private setSelectedAIAssistant(userPreferenceAIAssistant: string, copilotAvailable: boolean, geminiAvailable: boolean): string | null { | ||
| let assistantType: string | null = null; | ||
| this.logs.info(`[DEBUG] setSelectedAIAssistant - copilotAvailable: ${copilotAvailable}, geminiAvailable: ${geminiAvailable}`); |
Contributor
There was a problem hiding this comment.
Change log level from info to debug .
| if (isIDE(constants.kiroAgent)) { | ||
| return path.join(homeDir, ".kiro", "settings", "mcp.json"); | ||
| } | ||
| if (isIDE(constants.geminiAgent)) { |
Contributor
There was a problem hiding this comment.
I think here we need to check the condition of AI assistant selection and based on that configure mcp
| ...((isIDE(constants.windsurfAgent) || isIDE(constants.windsurfNextAgent)) ? { serverUrl: fullUrl } : { url: fullUrl }), | ||
| headers: { | ||
| "cx-origin": isIDE(constants.kiroAgent) ? constants.kiroAgent : (isIDE(constants.windsurfNextAgent) || isIDE(constants.windsurfAgent)) ? constants.windsurfAgent : isIDE(constants.cursorAgent) ? constants.cursorAgent : "VsCode", | ||
| "cx-origin": isIDE(constants.kiroAgent) ? constants.kiroAgent : |
Contributor
There was a problem hiding this comment.
constants.geminiAgent is not IDE - it should pass ide name only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Checkmarx Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
References
Testing
Checklist