Fix outdated expected URL in SDF legacy path unit test#8
Merged
sfluegel05 merged 2 commits intodevfrom Mar 16, 2026
Merged
Conversation
Co-authored-by: sfluegel05 <43573433+sfluegel05@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unit test for SDF legacy path
Fix outdated expected URL in SDF legacy path unit test
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_sdf_url_legacy_versionwas asserting an OBO URL (/ontology/chebi.obo) as the expected result of_chebi_sdf_url()for a legacy version — a copy-paste error. The implementation indownloader.pywas already correct.Change
tests/test_downloader.py: Updated the expected URL intest_sdf_url_legacy_versionto the correct SDF path:Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.