Skip to content

Fix outdated expected URL in SDF legacy path unit test#8

Merged
sfluegel05 merged 2 commits intodevfrom
copilot/fix-sdf-legacy-path-tests
Mar 16, 2026
Merged

Fix outdated expected URL in SDF legacy path unit test#8
sfluegel05 merged 2 commits intodevfrom
copilot/fix-sdf-legacy-path-tests

Conversation

Copy link
Contributor

Copilot AI commented Mar 16, 2026

test_sdf_url_legacy_version was asserting an OBO URL (/ontology/chebi.obo) as the expected result of _chebi_sdf_url() for a legacy version — a copy-paste error. The implementation in downloader.py was already correct.

Change

  • tests/test_downloader.py: Updated the expected URL in test_sdf_url_legacy_version to the correct SDF path:
    …/archive/chebi_legacy/archive/rel230/SDF/ChEBI_complete.sdf.gz
    
    instead of the incorrect OBO path:
    …/archive/chebi_legacy/archive/rel230/ontology/chebi.obo
    
Original prompt

This section details on the original issue you should resolve

<issue_title>Unit test fails for SDF legacy path</issue_title>
<issue_description>The currently implemented URL for downloading legacy SDF files is correct. The test is outdated.

@copilot please fix</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: sfluegel05 <43573433+sfluegel05@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix unit test for SDF legacy path Fix outdated expected URL in SDF legacy path unit test Mar 16, 2026
Copilot AI requested a review from sfluegel05 March 16, 2026 17:18
@sfluegel05 sfluegel05 marked this pull request as ready for review March 16, 2026 17:24
@sfluegel05 sfluegel05 merged commit 75aefac into dev Mar 16, 2026
8 checks passed
@sfluegel05 sfluegel05 deleted the copilot/fix-sdf-legacy-path-tests branch March 16, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test fails for SDF legacy path

2 participants