Open
Conversation
jmdegeorge
reviewed
Mar 13, 2025
| // version = "20250101" | ||
| //version = versionLabel(versionDetails()) | ||
|
|
||
| version = "2.2.0" |
There was a problem hiding this comment.
When you want to build a versioned release, you just have to set the tag name to the version you are building.
That process is detailed here:
Contributor
Author
|
Thank you and I will try again.
________________________________
From: Joshua DeGeorge ***@***.***>
Sent: Thursday, March 13, 2025 1:58:31 PM
To: CentralValleyModeling/wrims ***@***.***>
Cc: Xie, ***@***.*** ***@***.***>; Author ***@***.***>
Subject: Re: [CentralValleyModeling/wrims] Feature/version2.2.0 (PR #212)
@jmdegeorge commented on this pull request.
________________________________
In build.gradle<#212 (comment)>:
@@ -23,6 +23,7 @@ def versionLabel(gitInfo) {
allprojects {
group = 'gov.ca.dwr'
- version = versionLabel(versionDetails())
-// version = "20250101"
+ //version = versionLabel(versionDetails())
+
+ version = "2.2.0"
When you want to build a versioned release, you just have to set the tag name to the version you are building.
That process is detailed here:
https://github.com/CentralValleyModeling/wrims/blob/Feature/wrims-devops/README.build-gradle.md#how-to-build-wrims-installer-from-github-releases
—
Reply to this email directly, view it on GitHub<#212 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7C7KRW26CDJ4AJPX3IQX32UHWPPAVCNFSM6AAAAABY7HBP4WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOBTGM2TCMBYG4>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Contributor
Author
|
It looks like the installer created through tag is significantly larger than the Gradle building through Eclipse.
From: Joshua DeGeorge ***@***.***>
Sent: Thursday, March 13, 2025 1:59 PM
To: CentralValleyModeling/wrims ***@***.***>
Cc: Xie, ***@***.*** ***@***.***>; Author ***@***.***>
Subject: Re: [CentralValleyModeling/wrims] Feature/version2.2.0 (PR #212)
@jmdegeorge commented on this pull request.
________________________________
In build.gradle<#212 (comment)>:
@@ -23,6 +23,7 @@ def versionLabel(gitInfo) {
allprojects {
group = 'gov.ca.dwr'
- version = versionLabel(versionDetails())
-// version = "20250101"
+ //version = versionLabel(versionDetails())
+
+ version = "2.2.0"
When you want to build a versioned release, you just have to set the tag name to the version you are building.
That process is detailed here:
https://github.com/CentralValleyModeling/wrims/blob/Feature/wrims-devops/README.build-gradle.md#how-to-build-wrims-installer-from-github-releases
-
Reply to this email directly, view it on GitHub<#212 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7C7KRW26CDJ4AJPX3IQX32UHWPPAVCNFSM6AAAAABY7HBP4WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMOBTGM2TCMBYG4>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please approve this change and I will do some final test.