Open
Conversation
zack-rma
changed the title
docs/design-records/python-usage.md
Outdated
| [Pull Request #67](https://github.com/CentralValleyModeling/wrims-engine/pull/67). | ||
|
|
||
| #### Pros: | ||
| - Already integrated as a Gradle dependency. |
There was a problem hiding this comment.
This needs to be revised as Graal is in the project as a prototype/proof of concept example. That shouldn't carry much weight went it comes to JEP vs Graal as it is not use in production or test code for engine.
docs/design-records/python-usage.md
Outdated
|
|
||
| ### Option 3: Maintain the Status Quo | ||
|
|
||
| Keep both GraalPy (for tests) and JEP (for `Functionsuitablehabitat`) without change. |
There was a problem hiding this comment.
This needs revision given GraalPy is only present as an example
docs/design-records/python-usage.md
Outdated
|
|
||
| #### Pros: | ||
| - Zero effort is required immediately. | ||
| - GraalPy provides modern Python functionality for future use. |
| exists to validate JEP is currently functioning as intended. | ||
| - Requires continued inclusion of an additional DLL file in the WRIMS-GUI project. | ||
| - JEP may become stale or incompatible with future Java/Python versions. | ||
| - No test coverage exists to validate JEP is currently functioning as intended. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds documentation describing current Python usages within WRIMS-Engine.
Motivation and Context
Documentation addresses #206
Types of changes
Notes for Reviewers
Please consider the following when reviewing this PR: