Open
Conversation
…ocumentation. Added additional tests.
…back in. Added UUID field
zack-rma
force-pushed
the
feature/service-loading-example
branch
from
7f5f4bd to
29a3fc4
Compare
|
|
||
| import java.util.UUID; | ||
|
|
||
| public interface Solver |
There was a problem hiding this comment.
this interface should not be in the implementation package as it cannot be depended on by the application
Contributor
Author
There was a problem hiding this comment.
Moved to service package
| import java.util.Map; | ||
| import java.util.UUID; | ||
|
|
||
| import gov.ca.water.wrims.engine.core.solver.solvers.Solver; |
There was a problem hiding this comment.
This test should have no dependencies onto the solver package as that is service implementation only
Contributor
Author
There was a problem hiding this comment.
Removed dependencies
…on implementation. Updated documentation.
…ples. Removed README.
|
|
@zack-rma this looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Example implementation of service loader for solver-like test classes.
Motivation and Context
Provides examples to resolve #214
More information about the Netbeans Lookup API can be found here:
NetBeans Lookup.
See more about global singletons here:
Default Lookup.
Types of changes
Notes for Reviewers
Please consider the following when reviewing this PR: