fix PAINTROID-802 Add clear button to clipboard tool#1355
Open
anya-xcode wants to merge 1 commit intoCatrobat:developfrom
Open
fix PAINTROID-802 Add clear button to clipboard tool#1355anya-xcode wants to merge 1 commit intoCatrobat:developfrom
anya-xcode wants to merge 1 commit intoCatrobat:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a clear button to the clipboard tool, allowing users to explicitly free clipboard memory and reset the paste state. The implementation follows existing patterns in the codebase and properly handles memory management through safe bitmap recycling.
Key Changes:
- Added UI button and string resource for "Clear" functionality
- Extended the clipboard tool interface and implementation with clear callback
- Implemented
clearClipboardContent()method with proper memory management and state reset
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Paintroid/src/main/res/values/string.xml |
Added clipboard_tool_clear string resource for the clear button |
Paintroid/src/main/res/layout/dialog_pocketpaint_clipboard_tool.xml |
Added clear button chip with spacing, following the existing layout pattern |
Paintroid/src/main/java/org/catrobat/paintroid/tools/options/ClipboardToolOptionsView.kt |
Extended interface with clearClicked() callback method |
Paintroid/src/main/java/org/catrobat/paintroid/ui/tools/DefaultClipboardToolOptionsView.kt |
Implemented clear button initialization and click listener, maintaining logical ordering of chip initializations |
Paintroid/src/main/java/org/catrobat/paintroid/tools/implementation/ClipboardTool.kt |
Implemented clearClipboardContent() method with proper bitmap recycling, null safety, and state management |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Hi @ThorstenBandel and @juliajulie95, could you please review and merge this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAINTROID-802 Add clear button to clipboard tool
Summary
This PR adds a clear button to the clipboard tool, allowing users to clear the currently stored clipboard content without having to copy or cut new content.
Changes
dialog_pocketpaint_clipboard_tool.xml)clipboard_tool_clearstring resourceClipboardToolOptionsViewinterface withclearClicked()callback methodDefaultClipboardToolOptionsViewwith proper initialization and click listenerclearClipboardContent()method inClipboardToolthat:readyForPastestate to falseic_pocketpaint_layers_delete) for consistencyContext
Previously, users had no way to clear the stored clipboard content once they copied or cut an image area. The only workaround was to copy/cut new content to overwrite the existing clipboard data. This PR addresses that limitation by providing an explicit clear button.
Testing
The implementation follows existing patterns in the codebase and uses proper null safety with Kotlin's safe call operator. Manual testing should verify: