PAINTROID-684 Apply outline to text

[JulianJautz]

new button in Texttool for creating white text with outline in selected colour

• text is painted in two steps: first white filling, then outline in stroke mode

https://jira.catrob.at/browse/PAINTROID-684

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

• Include the name of the Jira ticket in the PR’s title
• Include a summary of the changes plus the relevant context
• Choose the proper base branch (develop)
• Confirm that the changes follow the project’s coding guidelines
• Verify that the changes generate no compiler or linter warnings
• Perform a self-review of the changes
• Verify to commit no other files than the intentionally changed ones
• Include reasonable and readable tests verifying the added or changed behavior
• Confirm that new and existing unit tests pass locally
• Check that the commits’ message style matches the project’s guideline
• Stick to the project’s gitflow workflow
• Verify that your changes do not have any conflicts with the base branch
• After the PR, verify that all CI checks have passed
• Post a message in the #paintroid Slack channel and ask for a code reviewer

[khalid-nasralla]

Code looks good to me and the outlining works really good.

One small thing I noticed, but I dont think it has something to do with how the outlining was implemented, is that sometimes depending on the text font that is being used, the outlines of a character intersect. This is especially noticable when also using Boldness on the text that uses Outlines. I noticed this with the text fonts "Sans Serif" and "STC", with other fonts, this problem doesnt occur.

[khalid-nasralla]

If there is something that can be done against this problem, it would be nice, else I would still approve it and I think its definitely worth merging as this is a great feature. Maybe we can then create a separate ticket for this text font problem

[JulianJautz]

If there is something that can be done against this problem, it would be nice, else I would still approve it and I think its definitely worth merging as this is a great feature. Maybe we can then create a separate ticket for this text font problem

Yes, I also noticed this behaviour. Interestingly, it seems like it depends on the Android version on the phone. I don't know exactly, but the issue with "STC" starts around API 30, with "Sans Serif" even later. The two fonts did not have a displaying issue with older version, when I tested it. I thought about some ways to fix it, but could not come up with a solution (e.g. painting the outline first would mean that it is not possible to make it bigger towards the middle but just to the border of the text).