CATTY-369 Implement place visually feature#1728
CATTY-369 Implement place visually feature#1728mstoeg wants to merge 3 commits intoCatrobat:developfrom
Conversation
b4a2496 to
a59adb4
Compare
wallisch
left a comment
There was a problem hiding this comment.
And rebase to develop please, then we're done IMO
src/Catty/ViewController/Stage/StagePresenterViewControllerScreenshotExtension.swift
Outdated
Show resolved
Hide resolved
|
Some issues:
Additionally, i would tint the status bar with light color mode (white) on the "place visually" screen |
ca8919c to
a8b77d9
Compare
|
Thank you, I fixed the requested changes. Concerning the navigation bar: I deliberately made it transparent, because if someone is creating a fullscreen app and wants to visually place an object at the top of the screen it would not be possible as the top area would be obscured by the navigation bar. |
|
I rebased and also made some small changes:
I think we're good to go now. |
m-herold
left a comment
There was a problem hiding this comment.
Very nice PR, thanks @mstoeg!
While this feature works perfectly for objects without any transformation, the place visually feature is misleading/does not apply transformations when an object is
- Turned left/right
- Pointed in a certain direction
- Changed its look
It however works fine when changing an object's size. In Catroid it seems that the last visible appearance is being cached and reused when using the place visually feature. Could we do the same for Catty?
Finally, this feature does not work for landscape mode. In case landscape mode needs a significant amount of rework, I am more than happy to implement the place visually feature for landscape mode in a separate ticket while merging this already (after the previously mentioned bugs have been implemented).
(https://jira.catrob.at/browse/CATTY-369)
Your checklist for this pull request
Please review the contributing guidelines and wiki pages of this repository.