Fix portTTICK_Period/portTICK_Rate, CONFIG_DAC_I2C_ADDR, tas5805m_fault_monitor_task#218
Open
Sturi2011 wants to merge 9 commits intoCarlosDerSeher:developfrom
Open
Fix portTTICK_Period/portTICK_Rate, CONFIG_DAC_I2C_ADDR, tas5805m_fault_monitor_task#218Sturi2011 wants to merge 9 commits intoCarlosDerSeher:developfrom
Sturi2011 wants to merge 9 commits intoCarlosDerSeher:developfrom
Conversation
merge develop to master
Signed-off-by: Karl Osterseher <karl_osterseher@gmx.at>
…o in Convert to pdMS_TO_TICKS
Owner
|
Is 3072 really needed? Can't we do less? |
Author
|
I will do some more testing this weekend after i soldered my third testing board. I will check.... Greetings Andreas |
Owner
|
Maybe you could place the fault strings to flash memory? As global consts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace of portTTICK_Period/portTICK_Rate by pdMS_TO_TICKS in driver and board
fix for hard coded i2c address in tas5805m_reg_cfg.h
extend tas5805m_fault_monitor_task to 3072 because of ESP32S3 minimum Task Size is about 1,6K