Preview: Snapclient component with reduced dependencies#207
Draft
luar123 wants to merge 22 commits intoCarlosDerSeher:developfrom
Draft
Preview: Snapclient component with reduced dependencies#207luar123 wants to merge 22 commits intoCarlosDerSeher:developfrom
luar123 wants to merge 22 commits intoCarlosDerSeher:developfrom
Conversation
* Add mDNS dep and handle IPv4-only mDNS addr Add `mdns` to the component private requirements because optional seems not to work. * Update components/snapclient/connection_handler.c --------- Co-authored-by: luar123 <49960470+luar123@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the branch I use for a new esphome component version. Functionally it is mostly the same as #203 but I moved http_get task and connection handler together with kconfig to a new snapclient component. Additionally, I made dependencies on network and settings_manager stuff optional, so it can be used more as a library.
Could also move it into the lightsnapcast component.
This PR is more fyi and to get your feedback.
(I don't want to get this merged. Maybe later when #201 is merged. There are also some disabled bluetooth experiments in main.c, just ignore them.)