Open
Conversation
src/AbstractAttachment.php
Outdated
| $this->uri = $uri; | ||
|
|
||
| return $this; | ||
| } |
Contributor
There was a problem hiding this comment.
IMO we shoud have getContents (and no SetContents... you do not change the content or the uri for any reason). IT's up to the adapter to be able to return this stuff.
krichprollsch
force-pushed
the
attachment
branch
2 times, most recently
from
c4b08fd to
321b639
Compare
Contributor
|
👍 |
krichprollsch
force-pushed
the
attachment
branch
2 times, most recently
from
c5aeb20 to
1484929
Compare
krichprollsch
force-pushed
the
attachment
branch
from
1484929 to
8863c6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gives the possibility to represent an attachment to an event.