Draft
Conversation
2996a21 to
439fcbb
Compare
Collaborator
|
euh, I can not recommend changing flatten... the way I think about it is that if it accepts expression trees (like z3), then it does not need flatten... flatten outputs FNF and expression trees are very much not FNF. So... ideally you follow the same flow as Z3; and if there are things that gurobi does not accept then you create a new transformation for that... (which can call flatten if it wants to) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial draft for supporting expression trees. I've had to make many changes to flatten to prevent it from flattening expressions which are supported by the Gurobi expression trees. Now that the Gurobi side is working, I'm making a 2nd pass to make things more principled and stable again, as of course now the other solvers would break. However, it will remain difficult, as we no longer have Flat Normal Form for the later Gurobi transformations.